Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs: Migrate to AWS SDK v2 #38016

Merged
merged 63 commits into from
Jul 18, 2024
Merged

ecs: Migrate to AWS SDK v2 #38016

merged 63 commits into from
Jul 18, 2024

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Jun 17, 2024 •
edited by jar-b
Loading

Description

Relations

Closes #36151
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@mattburgess mattburgess requested a review from a team as a code owner June 17, 2024 19:46
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Jun 17, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jun 17, 2024
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Jun 21, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 26, 2024
@ewbankkit
Merge branch 'main' into HEAD
00a919d 
# Conflicts:
#	internal/conns/awsclient_gen.go
#	internal/service/ecs/cluster.go
#	internal/service/ecs/find.go
#	internal/service/ecs/service_data_source.go
#	internal/service/ecs/service_package_gen.go
#	names/names.go
@ewbankkit
ecs: Comment out ContainerDefinitionsAreEquivalent tests.
fa7cf55
@ewbankkit
Merge branch 'main' into HEAD
b9a8294
@ewbankkit
d/aws_ecs_container_definition: Reduce visibility.
27f0618
@ewbankkit
r/aws_ecs_service: Reduce visibility.
10e8a0a
@ewbankkit
r/aws_ecs_task_definition: Reduce visibility.
5289211
@ewbankkit
d/aws_ecs_task_definition: Reduce visibility.
9559009
@ewbankkit
Eliminate use of 'github.com/aws/aws-sdk-go/private/protocol/json/jso…
6afe79d 
…nutil'.
@ewbankkit
d/aws_ecs_task_execution: Reduce visibility.
ddfed7c
@ewbankkit
r/aws_ecs_task_set: Reduce visibility.
9b43382
@ewbankkit
Fix golangci-lint 'unparam'.
dc56bb3
@ewbankkit
Fix golangci-lint 'unparam'.
1ada017
@ewbankkit
Merge branch 'main' into HEAD
51ef973
@ewbankkit
Cosmetics.
e7fd913
@ewbankkit
ecs: Tidy up sweepers.
86bfb11
@ewbankkit
r/aws_ecs_task_definition: Set 'arn' in Create.
2476b3e
@ewbankkit
Fix 'taskSetParseResourceID'.
dd157df
@ewbankkit
Fix 'TestAccECSService_PlacementStrategy_missing'.
7f700dd
@ewbankkit
ecs: Skip acceptance test errors like 'InvalidParameterException: ECS…
1b56aa7 
… managed EBS volume configuration was invalid for volume 'vol1'. Encountered 'VolumeTypeNotAvailableInZone' error from AmazonEC2: "The specified zone does not support gp3 volume type."'.
@ewbankkit
Fix 'TestAccECSService_PlacementStrategy_missing'.
8887eba
@ewbankkit
Fix 'TestAccECSTaskDefinition_invalidContainerDefinition'.
3c94609
ewbankkit
ewbankkit approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDynamoDBTableItem_' PKG=dynamodb ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/dynamodb/... -v -count 1 -parallel 3  -run=TestAccDynamoDBTableItem_ -timeout 360m
=== RUN   TestAccDynamoDBTableItem_basic
=== PAUSE TestAccDynamoDBTableItem_basic
=== RUN   TestAccDynamoDBTableItem_rangeKey
=== PAUSE TestAccDynamoDBTableItem_rangeKey
=== RUN   TestAccDynamoDBTableItem_withMultipleItems
=== PAUSE TestAccDynamoDBTableItem_withMultipleItems
=== RUN   TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey
=== PAUSE TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey
=== RUN   TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey
=== PAUSE TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey
=== RUN   TestAccDynamoDBTableItem_wonkyItems
=== PAUSE TestAccDynamoDBTableItem_wonkyItems
=== RUN   TestAccDynamoDBTableItem_update
=== PAUSE TestAccDynamoDBTableItem_update
=== RUN   TestAccDynamoDBTableItem_updateWithRangeKey
=== PAUSE TestAccDynamoDBTableItem_updateWithRangeKey
=== RUN   TestAccDynamoDBTableItem_disappears
=== PAUSE TestAccDynamoDBTableItem_disappears
=== RUN   TestAccDynamoDBTableItem_mapOutOfBandUpdate
=== PAUSE TestAccDynamoDBTableItem_mapOutOfBandUpdate
=== CONT  TestAccDynamoDBTableItem_basic
=== CONT  TestAccDynamoDBTableItem_wonkyItems
=== CONT  TestAccDynamoDBTableItem_disappears
--- PASS: TestAccDynamoDBTableItem_disappears (25.87s)
=== CONT  TestAccDynamoDBTableItem_mapOutOfBandUpdate
--- PASS: TestAccDynamoDBTableItem_basic (26.99s)
=== CONT  TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey
--- PASS: TestAccDynamoDBTableItem_wonkyItems (27.11s)
=== CONT  TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey
--- PASS: TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey (17.05s)
=== CONT  TestAccDynamoDBTableItem_withMultipleItems
--- PASS: TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey (19.25s)
=== CONT  TestAccDynamoDBTableItem_updateWithRangeKey
--- PASS: TestAccDynamoDBTableItem_mapOutOfBandUpdate (25.45s)
=== CONT  TestAccDynamoDBTableItem_update
--- PASS: TestAccDynamoDBTableItem_withMultipleItems (19.54s)
=== CONT  TestAccDynamoDBTableItem_rangeKey
--- PASS: TestAccDynamoDBTableItem_updateWithRangeKey (22.90s)
--- PASS: TestAccDynamoDBTableItem_update (26.09s)
--- PASS: TestAccDynamoDBTableItem_rangeKey (17.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	86.206s
% make testacc TESTARGS='-run=TestAccDMSCertificate_' PKG=dms ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSCertificate_ -timeout 360m
=== RUN   TestAccDMSCertificate_basic
=== PAUSE TestAccDMSCertificate_basic
=== RUN   TestAccDMSCertificate_disappears
=== PAUSE TestAccDMSCertificate_disappears
=== RUN   TestAccDMSCertificate_certificateWallet
=== PAUSE TestAccDMSCertificate_certificateWallet
=== RUN   TestAccDMSCertificate_tags
=== PAUSE TestAccDMSCertificate_tags
=== CONT  TestAccDMSCertificate_basic
=== CONT  TestAccDMSCertificate_certificateWallet
=== CONT  TestAccDMSCertificate_disappears
--- PASS: TestAccDMSCertificate_disappears (9.99s)
=== CONT  TestAccDMSCertificate_tags
--- PASS: TestAccDMSCertificate_certificateWallet (12.22s)
--- PASS: TestAccDMSCertificate_basic (12.22s)
--- PASS: TestAccDMSCertificate_tags (24.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	39.517s
% make testacc TESTARGS='-run=TestAccAppRunnerConnection_' PKG=apprunner ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/apprunner/... -v -count 1 -parallel 3  -run=TestAccAppRunnerConnection_ -timeout 360m
=== RUN   TestAccAppRunnerConnection_basic
=== PAUSE TestAccAppRunnerConnection_basic
=== RUN   TestAccAppRunnerConnection_disappears
=== PAUSE TestAccAppRunnerConnection_disappears
=== RUN   TestAccAppRunnerConnection_tags
=== PAUSE TestAccAppRunnerConnection_tags
=== CONT  TestAccAppRunnerConnection_basic
=== CONT  TestAccAppRunnerConnection_tags
=== CONT  TestAccAppRunnerConnection_disappears
--- PASS: TestAccAppRunnerConnection_disappears (10.54s)
--- PASS: TestAccAppRunnerConnection_basic (12.55s)
--- PASS: TestAccAppRunnerConnection_tags (25.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	30.617s
% make testacc TESTARGS='-run=TestAccAppStreamUser_\|TestAccAppStreamImageBuilder_' PKG=appstream ACCTEST_PARALLELISM=3 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/appstream/... -v -count 1 -parallel 3  -run=TestAccAppStreamUser_\|TestAccAppStreamImageBuilder_ -timeout 360m
=== RUN   TestAccAppStreamImageBuilder_basic
=== PAUSE TestAccAppStreamImageBuilder_basic
=== RUN   TestAccAppStreamImageBuilder_withIAMRole
=== PAUSE TestAccAppStreamImageBuilder_withIAMRole
=== RUN   TestAccAppStreamImageBuilder_disappears
=== PAUSE TestAccAppStreamImageBuilder_disappears
=== RUN   TestAccAppStreamImageBuilder_complete
=== PAUSE TestAccAppStreamImageBuilder_complete
=== RUN   TestAccAppStreamImageBuilder_tags
=== PAUSE TestAccAppStreamImageBuilder_tags
=== RUN   TestAccAppStreamImageBuilder_imageARN
=== PAUSE TestAccAppStreamImageBuilder_imageARN
=== RUN   TestAccAppStreamUser_basic
=== PAUSE TestAccAppStreamUser_basic
=== RUN   TestAccAppStreamUser_disappears
=== PAUSE TestAccAppStreamUser_disappears
=== RUN   TestAccAppStreamUser_complete
=== PAUSE TestAccAppStreamUser_complete
=== CONT  TestAccAppStreamImageBuilder_basic
=== CONT  TestAccAppStreamImageBuilder_imageARN
=== CONT  TestAccAppStreamImageBuilder_complete
--- PASS: TestAccAppStreamImageBuilder_basic (578.90s)
=== CONT  TestAccAppStreamImageBuilder_tags
--- PASS: TestAccAppStreamImageBuilder_imageARN (578.99s)
=== CONT  TestAccAppStreamImageBuilder_disappears
--- PASS: TestAccAppStreamImageBuilder_complete (1106.53s)
=== CONT  TestAccAppStreamUser_disappears
--- PASS: TestAccAppStreamImageBuilder_disappears (536.62s)
=== CONT  TestAccAppStreamUser_complete
--- PASS: TestAccAppStreamUser_disappears (16.96s)
=== CONT  TestAccAppStreamImageBuilder_withIAMRole
--- PASS: TestAccAppStreamImageBuilder_tags (560.80s)
=== CONT  TestAccAppStreamUser_basic
--- PASS: TestAccAppStreamUser_basic (25.15s)
--- PASS: TestAccAppStreamUser_complete (49.40s)
--- PASS: TestAccAppStreamImageBuilder_withIAMRole (579.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	1707.281s
% make testacc TESTARGS='-run=TestAccAutoScalingLifecycleHook_' PKG=autoscaling ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/autoscaling/... -v -count 1 -parallel 3  -run=TestAccAutoScalingLifecycleHook_ -timeout 360m
=== RUN   TestAccAutoScalingLifecycleHook_basic
=== PAUSE TestAccAutoScalingLifecycleHook_basic
=== RUN   TestAccAutoScalingLifecycleHook_disappears
=== PAUSE TestAccAutoScalingLifecycleHook_disappears
=== RUN   TestAccAutoScalingLifecycleHook_omitDefaultResult
=== PAUSE TestAccAutoScalingLifecycleHook_omitDefaultResult
=== CONT  TestAccAutoScalingLifecycleHook_basic
=== CONT  TestAccAutoScalingLifecycleHook_omitDefaultResult
=== CONT  TestAccAutoScalingLifecycleHook_disappears
--- PASS: TestAccAutoScalingLifecycleHook_omitDefaultResult (151.45s)
--- PASS: TestAccAutoScalingLifecycleHook_disappears (179.05s)
--- PASS: TestAccAutoScalingLifecycleHook_basic (209.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	214.342s
% make testacc TESTARGS='-run=TestAccECRLifecyclePolicy' PKG=ecr ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ecr/... -v -count 1 -parallel 3  -run=TestAccECRLifecyclePolicy -timeout 360m
=== RUN   TestAccECRLifecyclePolicyDocumentDataSource_basic
--- PASS: TestAccECRLifecyclePolicyDocumentDataSource_basic (5.92s)
=== RUN   TestAccECRLifecyclePolicy_basic
=== PAUSE TestAccECRLifecyclePolicy_basic
=== RUN   TestAccECRLifecyclePolicy_disappears
=== PAUSE TestAccECRLifecyclePolicy_disappears
=== RUN   TestAccECRLifecyclePolicy_ignoreEquivalent
=== PAUSE TestAccECRLifecyclePolicy_ignoreEquivalent
=== RUN   TestAccECRLifecyclePolicy_detectDiff
=== PAUSE TestAccECRLifecyclePolicy_detectDiff
=== RUN   TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== PAUSE TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== CONT  TestAccECRLifecyclePolicy_basic
=== CONT  TestAccECRLifecyclePolicy_detectDiff
=== CONT  TestAccECRLifecyclePolicy_detectTagPatternListDiff
--- PASS: TestAccECRLifecyclePolicy_basic (11.87s)
=== CONT  TestAccECRLifecyclePolicy_ignoreEquivalent
--- PASS: TestAccECRLifecyclePolicy_detectDiff (13.53s)
=== CONT  TestAccECRLifecyclePolicy_disappears
--- PASS: TestAccECRLifecyclePolicy_detectTagPatternListDiff (13.59s)
--- PASS: TestAccECRLifecyclePolicy_disappears (9.63s)
--- PASS: TestAccECRLifecyclePolicy_ignoreEquivalent (12.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	34.781s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccECS' PKG=ecs ACCTEST_PARALLELISM=4        
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 4  -run=TestAccECS -timeout 720m
=== RUN   TestAccECSAccountSettingDefault_serial
=== PAUSE TestAccECSAccountSettingDefault_serial
=== RUN   TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN   TestAccECSCapacityProvider_disappears
=== PAUSE TestAccECSCapacityProvider_disappears
=== RUN   TestAccECSCapacityProvider_managedScaling
=== PAUSE TestAccECSCapacityProvider_managedScaling
=== RUN   TestAccECSCapacityProvider_managedScalingPartial
=== PAUSE TestAccECSCapacityProvider_managedScalingPartial
=== RUN   TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== RUN   TestAccECSClusterCapacityProviders_basic
=== PAUSE TestAccECSClusterCapacityProviders_basic
=== RUN   TestAccECSClusterCapacityProviders_disappears
=== PAUSE TestAccECSClusterCapacityProviders_disappears
=== RUN   TestAccECSClusterCapacityProviders_defaults
=== PAUSE TestAccECSClusterCapacityProviders_defaults
=== RUN   TestAccECSClusterCapacityProviders_destroy
=== PAUSE TestAccECSClusterCapacityProviders_destroy
=== RUN   TestAccECSClusterCapacityProviders_Update_capacityProviders
=== PAUSE TestAccECSClusterCapacityProviders_Update_capacityProviders
=== RUN   TestAccECSClusterCapacityProviders_Update_defaultStrategy
=== PAUSE TestAccECSClusterCapacityProviders_Update_defaultStrategy
=== RUN   TestAccECSClusterDataSource_ecsCluster
=== PAUSE TestAccECSClusterDataSource_ecsCluster
=== RUN   TestAccECSClusterDataSource_ecsClusterContainerInsights
=== PAUSE TestAccECSClusterDataSource_ecsClusterContainerInsights
=== RUN   TestAccECSClusterDataSource_tags
=== PAUSE TestAccECSClusterDataSource_tags
=== RUN   TestAccECSCluster_basic
=== PAUSE TestAccECSCluster_basic
=== RUN   TestAccECSCluster_disappears
=== PAUSE TestAccECSCluster_disappears
=== RUN   TestAccECSCluster_tags
=== PAUSE TestAccECSCluster_tags
=== RUN   TestAccECSCluster_serviceConnectDefaults
=== PAUSE TestAccECSCluster_serviceConnectDefaults
=== RUN   TestAccECSCluster_containerInsights
=== PAUSE TestAccECSCluster_containerInsights
=== RUN   TestAccECSCluster_configuration
=== PAUSE TestAccECSCluster_configuration
=== RUN   TestAccECSCluster_managedStorageConfiguration
=== PAUSE TestAccECSCluster_managedStorageConfiguration
=== RUN   TestAccECSContainerDefinitionDataSource_ecsContainerDefinition
=== PAUSE TestAccECSContainerDefinitionDataSource_ecsContainerDefinition
=== RUN   TestAccECSServiceDataSource_basic
=== PAUSE TestAccECSServiceDataSource_basic
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSService_disappears
=== PAUSE TestAccECSService_disappears
=== RUN   TestAccECSService_PlacementStrategy_unnormalized
=== PAUSE TestAccECSService_PlacementStrategy_unnormalized
=== RUN   TestAccECSService_CapacityProviderStrategy_basic
=== PAUSE TestAccECSService_CapacityProviderStrategy_basic
=== RUN   TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== PAUSE TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== RUN   TestAccECSService_CapacityProviderStrategy_update
=== PAUSE TestAccECSService_CapacityProviderStrategy_update
=== RUN   TestAccECSService_VolumeConfiguration_basic
=== PAUSE TestAccECSService_VolumeConfiguration_basic
=== RUN   TestAccECSService_VolumeConfiguration_update
=== PAUSE TestAccECSService_VolumeConfiguration_update
=== RUN   TestAccECSService_familyAndRevision
=== PAUSE TestAccECSService_familyAndRevision
=== RUN   TestAccECSService_healthCheckGracePeriodSeconds
=== PAUSE TestAccECSService_healthCheckGracePeriodSeconds
=== RUN   TestAccECSService_iamRole
=== PAUSE TestAccECSService_iamRole
=== RUN   TestAccECSService_DeploymentControllerType_codeDeploy
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeploy
=== RUN   TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== RUN   TestAccECSService_DeploymentControllerType_external
=== PAUSE TestAccECSService_DeploymentControllerType_external
=== RUN   TestAccECSService_alarmsAdd
=== PAUSE TestAccECSService_alarmsAdd
=== RUN   TestAccECSService_alarmsUpdate
=== PAUSE TestAccECSService_alarmsUpdate
=== RUN   TestAccECSService_DeploymentValues_basic
=== PAUSE TestAccECSService_DeploymentValues_basic
=== RUN   TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== PAUSE TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== RUN   TestAccECSService_deploymentCircuitBreaker
=== PAUSE TestAccECSService_deploymentCircuitBreaker
=== RUN   TestAccECSService_loadBalancerChanges
=== PAUSE TestAccECSService_loadBalancerChanges
=== RUN   TestAccECSService_clusterName
=== PAUSE TestAccECSService_clusterName
=== RUN   TestAccECSService_alb
=== PAUSE TestAccECSService_alb
=== RUN   TestAccECSService_multipleTargetGroups
=== PAUSE TestAccECSService_multipleTargetGroups
=== RUN   TestAccECSService_forceNewDeployment
=== PAUSE TestAccECSService_forceNewDeployment
=== RUN   TestAccECSService_forceNewDeploymentTriggers
=== PAUSE TestAccECSService_forceNewDeploymentTriggers
=== RUN   TestAccECSService_PlacementStrategy_basic
=== PAUSE TestAccECSService_PlacementStrategy_basic
=== RUN   TestAccECSService_PlacementStrategy_missing
=== PAUSE TestAccECSService_PlacementStrategy_missing
=== RUN   TestAccECSService_PlacementConstraints_basic
=== PAUSE TestAccECSService_PlacementConstraints_basic
=== RUN   TestAccECSService_PlacementConstraints_emptyExpression
=== PAUSE TestAccECSService_PlacementConstraints_emptyExpression
=== RUN   TestAccECSService_LaunchTypeFargate_basic
=== PAUSE TestAccECSService_LaunchTypeFargate_basic
=== RUN   TestAccECSService_LaunchTypeFargate_platformVersion
=== PAUSE TestAccECSService_LaunchTypeFargate_platformVersion
=== RUN   TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== RUN   TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== RUN   TestAccECSService_LaunchTypeEC2_network
=== PAUSE TestAccECSService_LaunchTypeEC2_network
=== RUN   TestAccECSService_DaemonSchedulingStrategy_basic
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_basic
=== RUN   TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== RUN   TestAccECSService_replicaSchedulingStrategy
=== PAUSE TestAccECSService_replicaSchedulingStrategy
=== RUN   TestAccECSService_ServiceRegistries_basic
=== PAUSE TestAccECSService_ServiceRegistries_basic
=== RUN   TestAccECSService_ServiceRegistries_container
=== PAUSE TestAccECSService_ServiceRegistries_container
=== RUN   TestAccECSService_ServiceRegistries_changes
=== PAUSE TestAccECSService_ServiceRegistries_changes
=== RUN   TestAccECSService_ServiceRegistries_removal
=== PAUSE TestAccECSService_ServiceRegistries_removal
=== RUN   TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN   TestAccECSService_ServiceConnect_full
=== PAUSE TestAccECSService_ServiceConnect_full
=== RUN   TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== PAUSE TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== RUN   TestAccECSService_ServiceConnect_ingressPortOverride
=== PAUSE TestAccECSService_ServiceConnect_ingressPortOverride
=== RUN   TestAccECSService_ServiceConnect_remove
=== PAUSE TestAccECSService_ServiceConnect_remove
=== RUN   TestAccECSService_Tags_basic
=== PAUSE TestAccECSService_Tags_basic
=== RUN   TestAccECSService_Tags_managed
=== PAUSE TestAccECSService_Tags_managed
=== RUN   TestAccECSService_Tags_propagate
=== PAUSE TestAccECSService_Tags_propagate
=== RUN   TestAccECSService_executeCommand
=== PAUSE TestAccECSService_executeCommand
=== RUN   TestAccECSTag_basic
=== PAUSE TestAccECSTag_basic
=== RUN   TestAccECSTag_disappears
=== PAUSE TestAccECSTag_disappears
=== RUN   TestAccECSTag_ResourceARN_batchComputeEnvironment
=== PAUSE TestAccECSTag_ResourceARN_batchComputeEnvironment
=== RUN   TestAccECSTag_value
=== PAUSE TestAccECSTag_value
=== RUN   TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== PAUSE TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_scratchVolume
=== PAUSE TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSTaskDefinition_configuredAtLaunch
=== PAUSE TestAccECSTaskDefinition_configuredAtLaunch
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_minimal
=== PAUSE TestAccECSTaskDefinition_DockerVolume_minimal
=== RUN   TestAccECSTaskDefinition_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== RUN   TestAccECSTaskDefinition_EFSVolume_minimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_minimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== RUN   TestAccECSTaskDefinition_fsxWinFileSystem
=== PAUSE TestAccECSTaskDefinition_fsxWinFileSystem
=== RUN   TestAccECSTaskDefinition_DockerVolume_taskScoped
=== PAUSE TestAccECSTaskDefinition_DockerVolume_taskScoped
=== RUN   TestAccECSTaskDefinition_service
=== PAUSE TestAccECSTaskDefinition_service
=== RUN   TestAccECSTaskDefinition_taskRoleARN
=== PAUSE TestAccECSTaskDefinition_taskRoleARN
=== RUN   TestAccECSTaskDefinition_networkMode
=== PAUSE TestAccECSTaskDefinition_networkMode
=== RUN   TestAccECSTaskDefinition_ipcMode
=== PAUSE TestAccECSTaskDefinition_ipcMode
=== RUN   TestAccECSTaskDefinition_pidMode
=== PAUSE TestAccECSTaskDefinition_pidMode
=== RUN   TestAccECSTaskDefinition_constraint
=== PAUSE TestAccECSTaskDefinition_constraint
=== RUN   TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccECSTaskDefinition_arrays
=== PAUSE TestAccECSTaskDefinition_arrays
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccECSTaskDefinition_executionRole
=== PAUSE TestAccECSTaskDefinition_executionRole
=== RUN   TestAccECSTaskDefinition_disappears
=== PAUSE TestAccECSTaskDefinition_disappears
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskDefinition_proxy
=== PAUSE TestAccECSTaskDefinition_proxy
=== RUN   TestAccECSTaskDefinition_inferenceAccelerator
=== PAUSE TestAccECSTaskDefinition_inferenceAccelerator
=== RUN   TestAccECSTaskDefinition_invalidContainerDefinition
=== PAUSE TestAccECSTaskDefinition_invalidContainerDefinition
=== RUN   TestAccECSTaskDefinition_trackLatest
=== PAUSE TestAccECSTaskDefinition_trackLatest
=== RUN   TestAccECSTaskExecutionDataSource_basic
=== PAUSE TestAccECSTaskExecutionDataSource_basic
=== RUN   TestAccECSTaskExecutionDataSource_overrides
=== PAUSE TestAccECSTaskExecutionDataSource_overrides
=== RUN   TestAccECSTaskExecutionDataSource_tags
=== PAUSE TestAccECSTaskExecutionDataSource_tags
=== RUN   TestAccECSTaskSet_basic
=== PAUSE TestAccECSTaskSet_basic
=== RUN   TestAccECSTaskSet_withExternalId
=== PAUSE TestAccECSTaskSet_withExternalId
=== RUN   TestAccECSTaskSet_withScale
=== PAUSE TestAccECSTaskSet_withScale
=== RUN   TestAccECSTaskSet_disappears
=== PAUSE TestAccECSTaskSet_disappears
=== RUN   TestAccECSTaskSet_withCapacityProviderStrategy
=== PAUSE TestAccECSTaskSet_withCapacityProviderStrategy
=== RUN   TestAccECSTaskSet_withAlb
=== PAUSE TestAccECSTaskSet_withAlb
=== RUN   TestAccECSTaskSet_withLaunchTypeFargate
=== PAUSE TestAccECSTaskSet_withLaunchTypeFargate
=== RUN   TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion
=== PAUSE TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion
=== RUN   TestAccECSTaskSet_withServiceRegistries
=== PAUSE TestAccECSTaskSet_withServiceRegistries
=== RUN   TestAccECSTaskSet_tags
=== PAUSE TestAccECSTaskSet_tags
=== CONT  TestAccECSAccountSettingDefault_serial
=== CONT  TestAccECSTaskDefinition_configuredAtLaunch
=== CONT  TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSAccountSettingDefault_serial/vpcTrunking
=== CONT  TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSAccountSettingDefault_serial/containerInsights
--- PASS: TestAccECSTaskDefinition_configuredAtLaunch (12.25s)
=== CONT  TestAccECSTaskDefinition_basic
--- PASS: TestAccECSTaskDefinition_scratchVolume (12.35s)
=== CONT  TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
--- PASS: TestAccECSTaskDefinition_Fargate_basic (14.99s)
=== CONT  TestAccECSTag_value
--- PASS: TestAccECSTaskDefinitionDataSource_ecsTaskDefinition (9.58s)
=== CONT  TestAccECSTag_ResourceARN_batchComputeEnvironment
=== RUN   TestAccECSAccountSettingDefault_serial/fargateTaskRetirementWaitPeriod
--- PASS: TestAccECSTaskDefinition_basic (17.31s)
=== CONT  TestAccECSTag_disappears
=== RUN   TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat
--- PASS: TestAccECSTag_ResourceARN_batchComputeEnvironment (21.16s)
=== CONT  TestAccECSTag_basic
--- PASS: TestAccECSTag_value (28.44s)
=== CONT  TestAccECSService_executeCommand
=== RUN   TestAccECSAccountSettingDefault_serial/serviceLongARNFormat
--- PASS: TestAccECSTag_disappears (20.44s)
=== CONT  TestAccECSService_Tags_propagate
=== RUN   TestAccECSAccountSettingDefault_serial/taskLongARNFormat
--- PASS: TestAccECSTag_basic (21.57s)
=== CONT  TestAccECSService_Tags_managed
--- PASS: TestAccECSAccountSettingDefault_serial (65.28s)
    --- PASS: TestAccECSAccountSettingDefault_serial/vpcTrunking (12.14s)
    --- PASS: TestAccECSAccountSettingDefault_serial/containerInsights (10.70s)
    --- PASS: TestAccECSAccountSettingDefault_serial/fargateTaskRetirementWaitPeriod (10.31s)
    --- PASS: TestAccECSAccountSettingDefault_serial/containerInstanceLongARNFormat (10.83s)
    --- PASS: TestAccECSAccountSettingDefault_serial/serviceLongARNFormat (10.66s)
    --- PASS: TestAccECSAccountSettingDefault_serial/taskLongARNFormat (10.65s)
=== CONT  TestAccECSService_Tags_basic
--- PASS: TestAccECSService_executeCommand (75.84s)
=== CONT  TestAccECSService_ServiceConnect_remove
--- PASS: TestAccECSService_Tags_managed (57.34s)
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
--- PASS: TestAccECSService_Tags_propagate (74.78s)
=== CONT  TestAccECSService_ServiceConnect_tls_with_empty_timeout
--- PASS: TestAccECSService_Tags_basic (74.18s)
=== CONT  TestAccECSService_ServiceConnect_full
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (165.28s)
=== CONT  TestAccECSService_ServiceConnect_basic
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (163.19s)
=== CONT  TestAccECSService_ServiceRegistries_removal
--- PASS: TestAccECSService_ServiceConnect_full (154.42s)
=== CONT  TestAccECSTaskExecutionDataSource_tags
--- PASS: TestAccECSService_ServiceConnect_remove (185.14s)
=== CONT  TestAccECSTaskSet_tags
--- PASS: TestAccECSTaskSet_tags (65.72s)
=== CONT  TestAccECSTaskSet_withServiceRegistries
--- PASS: TestAccECSService_ServiceRegistries_removal (139.18s)
=== CONT  TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion
--- PASS: TestAccECSService_ServiceConnect_basic (147.23s)
=== CONT  TestAccECSTaskSet_withLaunchTypeFargate
--- PASS: TestAccECSTaskSet_withLaunchTypeFargate (51.40s)
=== CONT  TestAccECSTaskSet_withAlb
--- PASS: TestAccECSTaskSet_withServiceRegistries (119.57s)
=== CONT  TestAccECSTaskSet_withCapacityProviderStrategy
--- PASS: TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion (84.88s)
=== CONT  TestAccECSTaskSet_disappears
--- PASS: TestAccECSTaskSet_disappears (53.55s)
=== CONT  TestAccECSTaskSet_withScale
--- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (82.35s)
=== CONT  TestAccECSTaskSet_withExternalId
--- PASS: TestAccECSTaskExecutionDataSource_tags (281.54s)
=== CONT  TestAccECSTaskSet_basic
--- PASS: TestAccECSTaskSet_withExternalId (44.93s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
--- PASS: TestAccECSTaskSet_basic (49.00s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskSet_withScale (59.88s)
=== CONT  TestAccECSTaskDefinition_changeVolumesForcesNewResource
--- PASS: TestAccECSTaskDefinition_arrays (10.92s)
=== CONT  TestAccECSTaskDefinition_constraint
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (24.22s)
=== CONT  TestAccECSTaskDefinition_pidMode
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (17.31s)
=== CONT  TestAccECSTaskDefinition_ipcMode
--- PASS: TestAccECSTaskDefinition_constraint (12.25s)
=== CONT  TestAccECSTaskDefinition_networkMode
--- PASS: TestAccECSTaskDefinition_pidMode (11.46s)
=== CONT  TestAccECSTaskDefinition_taskRoleARN
--- PASS: TestAccECSTaskDefinition_ipcMode (11.54s)
=== CONT  TestAccECSTaskDefinition_service
--- PASS: TestAccECSTaskDefinition_networkMode (11.81s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_taskScoped
--- PASS: TestAccECSTaskDefinition_taskRoleARN (11.63s)
=== CONT  TestAccECSTaskDefinition_fsxWinFileSystem
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (8.25s)
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (10.51s)
=== CONT  TestAccECSTaskExecutionDataSource_overrides
--- PASS: TestAccECSTaskSet_withAlb (238.73s)
=== CONT  TestAccECSTaskExecutionDataSource_basic
--- PASS: TestAccECSTaskDefinition_service (109.02s)
=== CONT  TestAccECSService_ServiceRegistries_changes
--- PASS: TestAccECSTaskExecutionDataSource_overrides (282.79s)
=== CONT  TestAccECSService_ServiceRegistries_container
--- PASS: TestAccECSTaskExecutionDataSource_basic (261.33s)
=== CONT  TestAccECSService_ServiceRegistries_basic
--- PASS: TestAccECSService_ServiceRegistries_changes (262.21s)
=== CONT  TestAccECSService_replicaSchedulingStrategy
--- PASS: TestAccECSService_replicaSchedulingStrategy (29.08s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (24.30s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_ServiceRegistries_container (140.65s)
=== CONT  TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSService_ServiceRegistries_basic (120.31s)
=== CONT  TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (27.79s)
=== CONT  TestAccECSService_LaunchTypeFargate_waitForSteadyState
--- PASS: TestAccECSService_LaunchTypeEC2_network (114.25s)
=== CONT  TestAccECSService_LaunchTypeFargate_platformVersion
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (161.27s)
=== CONT  TestAccECSService_LaunchTypeFargate_basic
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (210.99s)
=== CONT  TestAccECSService_PlacementConstraints_emptyExpression
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (114.95s)
=== CONT  TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (60.08s)
=== CONT  TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (1.42s)
=== CONT  TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_LaunchTypeFargate_basic (115.16s)
=== CONT  TestAccECSService_forceNewDeploymentTriggers
--- PASS: TestAccECSService_PlacementConstraints_basic (65.63s)
=== CONT  TestAccECSService_forceNewDeployment
--- PASS: TestAccECSService_PlacementStrategy_basic (89.24s)
=== CONT  TestAccECSService_multipleTargetGroups
--- PASS: TestAccECSService_forceNewDeploymentTriggers (95.76s)
=== CONT  TestAccECSService_alb
--- PASS: TestAccECSService_forceNewDeployment (95.59s)
=== CONT  TestAccECSService_clusterName
--- PASS: TestAccECSService_clusterName (58.00s)
=== CONT  TestAccECSService_loadBalancerChanges
--- PASS: TestAccECSService_multipleTargetGroups (280.87s)
=== CONT  TestAccECSService_deploymentCircuitBreaker
--- PASS: TestAccECSService_alb (271.68s)
=== CONT  TestAccECSService_DeploymentValues_minZeroMaxOneHundred
--- PASS: TestAccECSService_loadBalancerChanges (244.71s)
=== CONT  TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_deploymentCircuitBreaker (57.51s)
=== CONT  TestAccECSService_alarmsUpdate
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (57.06s)
=== CONT  TestAccECSService_alarmsAdd
--- PASS: TestAccECSService_DeploymentValues_basic (57.86s)
=== CONT  TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSService_alarmsAdd (55.01s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
--- PASS: TestAccECSService_alarmsUpdate (64.85s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeploy
--- PASS: TestAccECSService_DeploymentControllerType_external (38.18s)
=== CONT  TestAccECSService_iamRole
--- PASS: TestAccECSService_iamRole (51.60s)
=== CONT  TestAccECSService_healthCheckGracePeriodSeconds
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (235.72s)
=== CONT  TestAccECSService_familyAndRevision
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (196.63s)
=== CONT  TestAccECSService_VolumeConfiguration_update
--- PASS: TestAccECSService_familyAndRevision (63.16s)
=== CONT  TestAccECSService_VolumeConfiguration_basic
--- PASS: TestAccECSService_VolumeConfiguration_basic (68.84s)
=== CONT  TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_VolumeConfiguration_update (116.00s)
=== CONT  TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (433.33s)
=== CONT  TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (118.15s)
=== CONT  TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (57.98s)
=== CONT  TestAccECSService_disappears
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (135.93s)
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSService_CapacityProviderStrategy_update (212.28s)
=== CONT  TestAccECSService_basic
--- PASS: TestAccECSService_basic (65.01s)
=== CONT  TestAccECSServiceDataSource_basic
--- PASS: TestAccECSServiceDataSource_basic (25.40s)
=== CONT  TestAccECSContainerDefinitionDataSource_ecsContainerDefinition
--- PASS: TestAccECSContainerDefinitionDataSource_ecsContainerDefinition (57.95s)
=== CONT  TestAccECSCluster_managedStorageConfiguration
--- PASS: TestAccECSService_disappears (188.07s)
=== CONT  TestAccECSCluster_configuration
--- PASS: TestAccECSService_basicImport (191.33s)
=== CONT  TestAccECSCluster_containerInsights
--- PASS: TestAccECSCluster_managedStorageConfiguration (55.02s)
=== CONT  TestAccECSCluster_serviceConnectDefaults
--- PASS: TestAccECSCluster_configuration (41.36s)
=== CONT  TestAccECSCluster_tags
--- PASS: TestAccECSCluster_containerInsights (53.01s)
=== CONT  TestAccECSCluster_disappears
--- PASS: TestAccECSCluster_tags (34.34s)
=== CONT  TestAccECSCluster_basic
--- PASS: TestAccECSCluster_disappears (19.45s)
=== CONT  TestAccECSClusterDataSource_tags
--- PASS: TestAccECSClusterDataSource_tags (19.18s)
=== CONT  TestAccECSClusterDataSource_ecsClusterContainerInsights
--- PASS: TestAccECSCluster_basic (21.17s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
--- PASS: TestAccECSClusterDataSource_ecsClusterContainerInsights (19.25s)
=== CONT  TestAccECSClusterDataSource_ecsCluster
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (19.77s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
--- PASS: TestAccECSClusterDataSource_ecsCluster (19.35s)
=== CONT  TestAccECSClusterCapacityProviders_Update_defaultStrategy
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled (20.05s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (20.11s)
=== CONT  TestAccECSClusterCapacityProviders_Update_capacityProviders
--- PASS: TestAccECSCluster_serviceConnectDefaults (127.93s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal (19.74s)
=== CONT  TestAccECSClusterCapacityProviders_destroy
    cluster_capacity_providers_test.go:120: Step 1/2 error: Check failed: Check 2/2 error: RegisteredContainerInstancesCount = 0, want 2
--- PASS: TestAccECSClusterCapacityProviders_Update_defaultStrategy (101.07s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (20.07s)
=== CONT  TestAccECSClusterCapacityProviders_defaults
--- PASS: TestAccECSClusterCapacityProviders_Update_capacityProviders (100.63s)
=== CONT  TestAccECSTaskDefinition_invalidContainerDefinition
--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (1.11s)
=== CONT  TestAccECSClusterCapacityProviders_disappears
--- PASS: TestAccECSClusterCapacityProviders_defaults (42.76s)
=== CONT  TestAccECSTaskDefinition_disappears
--- PASS: TestAccECSClusterCapacityProviders_disappears (51.33s)
=== CONT  TestAccECSClusterCapacityProviders_basic
--- PASS: TestAccECSTaskDefinition_disappears (15.00s)
=== CONT  TestAccECSTaskDefinition_proxy
--- FAIL: TestAccECSClusterCapacityProviders_destroy (139.58s)
=== CONT  TestAccECSCapacityProvider_tags
--- PASS: TestAccECSTaskDefinition_proxy (21.66s)
=== CONT  TestAccECSTaskDefinition_tags
--- PASS: TestAccECSClusterCapacityProviders_basic (42.36s)
=== CONT  TestAccECSCapacityProvider_managedScalingPartial
--- PASS: TestAccECSCapacityProvider_tags (44.91s)
=== CONT  TestAccECSTaskDefinition_executionRole
--- PASS: TestAccECSTaskDefinition_tags (34.31s)
=== CONT  TestAccECSCapacityProvider_managedScaling
--- PASS: TestAccECSTaskDefinition_executionRole (11.15s)
=== CONT  TestAccECSTaskDefinition_Fargate_ephemeralStorage
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (10.30s)
=== CONT  TestAccECSCapacityProvider_disappears
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (34.36s)
=== CONT  TestAccECSTaskDefinition_runtimePlatform
--- PASS: TestAccECSTaskDefinition_runtimePlatform (10.46s)
=== CONT  TestAccECSCapacityProvider_basic
--- PASS: TestAccECSCapacityProvider_disappears (32.47s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
--- PASS: TestAccECSCapacityProvider_managedScaling (53.32s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (10.42s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (10.55s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSCapacityProvider_basic (36.37s)
=== CONT  TestAccECSTaskDefinition_trackLatest
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (10.43s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (10.34s)
--- PASS: TestAccECSTaskDefinition_trackLatest (10.54s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (2480.30s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	3149.490s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change and is occurring in CI: #38408.

@ewbankkit
Copy link
Contributor

@mattburgess Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0e58082 into hashicorp:main Jul 18, 2024
39 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 18, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Jul 22, 2024
Closed
@ewbankkit ewbankkit mentioned this pull request Jul 30, 2024
Closed
This was referenced Aug 9, 2024
Closed
Closed
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/ecs Issues and PRs that pertain to the ecs service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.59.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] ECS (Elastic Container) Service
3 participants
@mattburgess @ewbankkit @justinretzolk